Add support for Stand Alone Nexus Operations#2280
Add support for Stand Alone Nexus Operations#2280Quinn-With-Two-Ns wants to merge 11 commits intotemporalio:mainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fe42e708a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // ID - The business identifier of the operation. | ||
| // | ||
| // Mandatory: No default. | ||
| ID string |
There was a problem hiding this comment.
ClientStartNexusOperationOptions introduces an ID field while the rest of the new Nexus API uses OperationID (GetNexusOperationHandleOptions, metadata structs, and the integration test callsites). This inconsistency makes normal usage patterns fail at compile time (unknown field OperationID) and effectively breaks the newly added standalone Nexus start API for callers who follow the surrounding API naming. Aligning this field name now avoids shipping an immediately incompatible public surface.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is to be consistent with Stand alone activities naming approach
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit d296109. Configure here.
|
Note this PR is missing support for otel I was planning on addressing that in a separate PR to keep the scope down |
Quinn-With-Two-Ns
force-pushed
the
NEXUS-289
branch
from
d296109 to
8d6e09e
Compare
3 participants
Add standalone Nexus operation support
Adds the ability to start, poll, describe, cancel, terminate, list, and count Nexus operations directly from the
client, outside of workflow context. This mirrors the standalone activity pattern and is based on the API we already reviewed the cross SDK design for.
API
Interceptor support
Adds 6 methods to ClientOutboundInterceptor: ExecuteNexusOperation, GetNexusOperationHandle, CancelNexusOperation,
TerminateNexusOperation, DescribeNexusOperation, PollNexusOperationResult. List and Count bypass the interceptor,
consistent with standalone activities.
Testing
Note
Medium Risk
Adds new experimental client-facing APIs and interceptor hooks that invoke new Nexus gRPC endpoints, which could affect client behavior and compatibility despite being additive. Integration coverage is included but CI currently disables the new standalone Nexus test suite in docker-compose runs.
Overview
Adds experimental standalone Nexus operation support to the Go SDK client, including
client.NewNexusClient/NexusClient.ExecuteOperationplus aNexusOperationHandlethat canGet,Describe,Cancel, andTerminateoperations, and newListNexusOperations/CountNexusOperationsvisibility queries.Extends the client interceptor surface with Nexus-specific hooks (execute/handle/cancel/terminate/describe/poll) and provides default forwarding implementations. Includes unit and integration tests for header propagation, validation, name resolution, and end-to-end standalone operation flows, plus updates dev-server flags/versioning and CI env to optionally disable these tests.
Reviewed by Cursor Bugbot for commit e75f138. Bugbot is set up for automated code reviews on this repo. Configure here.